Skip to content

Comments

West Midlands | Jan26 ITP | Ziad Ahmed | sprint 2 | Form Controls #1157

Open
ZiadMakkawi wants to merge 6 commits intoCodeYourFuture:mainfrom
ZiadMakkawi:Ziad/FormsPt3
Open

West Midlands | Jan26 ITP | Ziad Ahmed | sprint 2 | Form Controls #1157
ZiadMakkawi wants to merge 6 commits intoCodeYourFuture:mainfrom
ZiadMakkawi:Ziad/FormsPt3

Conversation

@ZiadMakkawi
Copy link

@ZiadMakkawi ZiadMakkawi commented Feb 7, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added the form based on the required assesment
  • The orginal work for some reason was deleted and i had to do it again
  • This is fixed now
  • Added Autocompelete and validation
  • Validation message now match the proper format
  • Made sure accessability is 100

@netlify
Copy link

netlify bot commented Feb 7, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit db99c74
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69985db79d5e4d0008f3586a
😎 Deploy Preview https://deploy-preview-1157--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@ZiadMakkawi ZiadMakkawi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 7, 2026
@ZiadMakkawi
Copy link
Author

ZiadMakkawi commented Feb 7, 2026

So the reason why my code only shows a small section being edited .Because, my first commit i ended up commiting the wireframe files with the Form ones so i had to redo the commits and the Pull Request

SlideGauge
SlideGauge reviewed Feb 7, 2026
View reviewed changes
Copy link

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no form is implemented in this PR, could you implement it please?

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
@ZiadMakkawi ZiadMakkawi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 13, 2026
@ZiadMakkawi ZiadMakkawi mentioned this pull request Feb 13, 2026
Open
@cjyuan
Copy link
Contributor

cjyuan commented Feb 13, 2026

@ZiadMakkawi

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@ZiadMakkawi
Copy link
Author

ZiadMakkawi commented Feb 13, 2026

The form changes weren't implemented because I accidentally deleted the commit history and pushed the version before the changes were added, resulting in an empty form.
This should be fixed now.

@jayshreehajgude2012 jayshreehajgude2012 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026
jayshreehajgude2012
jayshreehajgude2012 reviewed Feb 16, 2026
View reviewed changes
Copy link

@jayshreehajgude2012 jayshreehajgude2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use autocomplete property for form fields like name, email.
You can use validation message as title of the field.

@jayshreehajgude2012 jayshreehajgude2012 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 16, 2026
@ZiadMakkawi
Copy link
Author

ZiadMakkawi commented Feb 16, 2026

The autocomplete attribute for form fields (such as name and email) and the inclusion of validation messages via the title attribute are they recommendations or strict requirements ?
Regardless Ill add them

@jayshreehajgude2012 jayshreehajgude2012 added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 17, 2026
@ZiadMakkawi ZiadMakkawi removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 18, 2026
@wilsonadenuga wilsonadenuga added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 20, 2026
wilsonadenuga
wilsonadenuga reviewed Feb 20, 2026
View reviewed changes
Copy link

@wilsonadenuga wilsonadenuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your current Lighthouse accessibility score is 95, while the requirement is 100. Please review the Lighthouse report and resolve the remaining accessibility issues to meet the required score.

Also, regarding form markup: the input + label pairing can be simplified across the codebase

<input type="radio" id="size-xxl" name="size" value="XXL" />
<label for="size-xxl">XXL</label>

You can wrap the input inside the label:

<label>
  <input type="radio" name="size" value="XXL" />
  XXL
</label>

@wilsonadenuga wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 20, 2026
@ZiadMakkawi
Copy link
Author

ZiadMakkawi commented Feb 20, 2026

I will make the changes. The form markup was made like this for better readability

@ZiadMakkawi ZiadMakkawi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 20, 2026
@wilsonadenuga wilsonadenuga added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 20, 2026
@wilsonadenuga
Copy link

wilsonadenuga commented Feb 20, 2026

Changes look good 😎

@wilsonadenuga wilsonadenuga added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 20, 2026
@ZiadMakkawi
Copy link
Author

ZiadMakkawi commented Feb 20, 2026

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayshreehajgude2012 jayshreehajgude2012 Awaiting requested review from jayshreehajgude2012

@SlideGauge SlideGauge Awaiting requested review from SlideGauge

@wilsonadenuga wilsonadenuga Awaiting requested review from wilsonadenuga

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZiadMakkawi @cjyuan @wilsonadenuga @SlideGauge @jayshreehajgude2012